[2.0] Fix storing floats in Redis #477
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Has conflicts. |
|
@taylorotwell fixed |
Redis will only accept floats with a point decimal sign and not a comma decimal sign. The sign is determined by the system's locale setting (LC_NUMERIC) and if set to one that prefers a comma will cause Redis to store the float as a string instead of a comma. This change will make sure that before a float is stored it's always made sure that any comma is changed to a point. This was already done in some other parts of the system. Fixes #371
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Redis will only accept floats with a point decimal sign and not a comma decimal sign. The sign is determined by the system's locale setting (LC_NUMERIC) and if set to one that prefers a comma will cause Redis to store the float as a string instead of a comma.
This change will make sure that before a float is stored it's always made sure that any comma is changed to a point. This was already done in some other parts of the system.
Fixes #371