Skip to content

Commit

Permalink
Changed the column type of profile_photo_path to string(2048) (#794)
Browse files Browse the repository at this point in the history
As the TEXT type on some DBs, creates an column with a limit of 2/4 GB.

This should increase compatibly with other DBs, with no impact on the migration it self. But we DO limit the column length, which is a good thing for this column use case. As a good practice URI should not be longer then 2K.

There is no mention of max URI length in the RFC3986, but there are limitation imposed by the software like the browsers them self.
  • Loading branch information
rabin-io authored May 26, 2021
1 parent 7ed0cad commit e97e85d
Showing 1 changed file with 1 addition and 1 deletion.
Original file line number Diff line number Diff line change
Expand Up @@ -21,7 +21,7 @@ public function up()
$table->string('password');
$table->rememberToken();
$table->foreignId('current_team_id')->nullable();
$table->text('profile_photo_path')->nullable();
$table->string('profile_photo_path', 2048)->nullable();
$table->timestamps();
});
}
Expand Down

0 comments on commit e97e85d

Please sign in to comment.