Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[2.x] Drop Laravel 8.x support (and PHP < 8) #1082

Merged
merged 3 commits into from
Jul 5, 2022
Merged

Conversation

timacdonald
Copy link
Member

@timacdonald timacdonald commented Jul 5, 2022

Dropping Laravel 8.x support as:

  • Jetstream is only meant to be installed on "new applications". I interpret this as meaning composer create-project laravel/laravel app.

Adding conflict as:

  • Vite is only supported in laravel/framework:^9.19.0.

Dropping support for PHP < 8.0.2 as:

  • The current version of Laravel 9.x only supports PHP:^8.0.2.

I'm also not sure how Laravel approaches dropping version support with SemVer - especially when it comes to these started kits. I'm pretty sure dropping version support is not a "breaking change" in SemVer world.

Alternatively, we could back port Vite but this would probably also include ongoing feature improvements in laravel/framework around Vite as well.

Testing script:

composer create-project laravel/laravel jetstream-test \
  && cd jetstream-test \
  && composer require laravel/jetstream:drop-8.x-support-dev \
  && php artisan jetstream:install inertia \
  && sed -i "s/SESSION_DRIVER=database/SESSION_DRIVER=file/" .env \
  && npm install && npm run dev

php artisan serve

See also: laravel/breeze#167

@timacdonald timacdonald marked this pull request as ready for review July 5, 2022 01:24
@taylorotwell taylorotwell merged commit 5c6efcd into 2.x Jul 5, 2022
@taylorotwell taylorotwell deleted the drop-8.x-support branch July 5, 2022 02:48
@driesvints
Copy link
Member

Thanks @timacdonald. You can also remove the old testbench version next time (I updated the composer.json just now).

@timacdonald
Copy link
Member Author

thanks @driesvints - I didn't even consider that one! Will keep that in mind next time 👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants