Check current model supports HasTeams before trying to access team information. #1120
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
information. This would be useful for application with multiple user providers and uses Inertia. As an example, this will fixes laravel/nova-issues#4683 Signed-off-by: Mior Muhammad Zaki <[email protected]>
Signed-off-by: Mior Muhammad Zaki <[email protected]>
Signed-off-by: Mior Muhammad Zaki <[email protected]>
|
Do you have to resolve the user outside of the closures? I think it changes the time the user is resolved and may introduce some sort of bugs? |
Not really.
Most of the time it would force a page reload but I reverted that changes since it really trivial to the original changes for this PR. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This would be useful for applications with multiple user providers and uses Inertia (as
ShareInertiaDatamiddleware is appended to global web middleware). As an example, this will fix laravel/nova-issues#4683Signed-off-by: Mior Muhammad Zaki [email protected]