Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add focus styling for settings dropdown trigger button #1206

Merged
merged 1 commit into from
Dec 31, 2022
Merged

add focus styling for settings dropdown trigger button #1206

merged 1 commit into from
Dec 31, 2022

Conversation

thema-d
Copy link
Contributor

@thema-d thema-d commented Dec 30, 2022

This change adds a focus style to Settings Dropdown trigger button in a similar manner to the Teams Dropdown.

The following screenshots show the focused state of the buttons before and after.
P.S: I have bumped up the background color of the buttons in the screenshot for the sake of contrast.

Before
Screenshot from 2022-12-30 12-49-40

After
Screenshot from 2022-12-30 12-50-35

@driesvints
Copy link
Member

I think the current behavior is more desireable. The former is a switcher while the latter is a dropdown.

@thema-d
Copy link
Contributor Author

thema-d commented Dec 30, 2022

Hi @driesvints, Thanks for replying.
What about when navigating using a keyboard? The Trigger button will be focused but no indication that it can be clicked or so.

@driesvints
Copy link
Member

ah sorry, didn't realize this was a focus style. Seems okay to me 👍

@taylorotwell taylorotwell merged commit e03c3a9 into laravel:2.x Dec 31, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants