-
Notifications
You must be signed in to change notification settings - Fork 825
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Opt-in dark mode support #1209
Opt-in dark mode support #1209
Conversation
@fotrino thanks but looks a bit awkward. Can't we make it so it has completely white letters and no border on the icon? |
Might need to duplicate the SVG logo |
@driesvints thanks for the input, also thought it was a bit off but was trying to follow the existing SVG.
|
Looks much better! |
@driesvints the SVG are updated. Please let me know if there is anything else that needs to be looked into :) |
Thanks! |
Thanks @fotrino! |
I installed jetstream months ago, this morning I did a composer update. I never ran any jetstream:install --dark command Tonight my sites suddenly look weird with some parts in dark and some parts in white. It looks like this dark mode is not really opt in after all. Screenshot attached, hope it helps. I do like dark mode a lot but perhaps it is not ready yet |
This will have to be reverted. |
This reverts commit dcc3f9f.
Hi there, |
Jetstream uses Tailwind to handle dark mode. The Tailwind docs have a section on manually toggling dark mode at https://tailwindcss.com/docs/dark-mode#toggling-dark-mode-manually. |
This PR introduces opt-in dark mode support to Jetstream, borrowed from @jessarcher PR on Breeze
Following the previous mentioned PR, the dark mode classes will be stripped unless dark mode is enabled.
When installing livewire stack without dark mode, the components will be published in order to strip the dark classes from them.
Screenshots
Notes