Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[2.x] Inertia v1 #1219

Merged
merged 9 commits into from
Jan 17, 2023
Merged

[2.x] Inertia v1 #1219

merged 9 commits into from
Jan 17, 2023

Conversation

jessarcher
Copy link
Member

@jessarcher jessarcher commented Jan 15, 2023 •
edited
Loading

This PR updates the Inertia stack to Inertia 1.0.

TODO:

  • Determine appropriate ssr.noExternal setting in vite.config.js.

@jessarcher jessarcher marked this pull request as draft January 15, 2023 06:27
@jessarcher jessarcher changed the title Inertia v1 [2.x] Inertia v1 Jan 15, 2023
@jessarcher
Remove creation of Inertia config on SSR install
ab0c057 
This is no longer required as Inertia will automatically detect SSR.
@jessarcher
Remove ssr.noExternal from Vite config
b985135 
This doesn't seem to be required any longer.
@jessarcher jessarcher marked this pull request as ready for review January 17, 2023 00:36
@timacdonald timacdonald mentioned this pull request Jan 17, 2023
Closed
@taylorotwell taylorotwell merged commit ea9799f into 2.x Jan 17, 2023
@taylorotwell taylorotwell deleted the inertia-v1 branch January 17, 2023 14:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@timacdonald timacdonald timacdonald approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@jessarcher @timacdonald @taylorotwell