Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Skip DeleteAccountTest if feature is not enabled #641

Merged
merged 3 commits into from
Jan 18, 2021
Merged

Skip DeleteAccountTest if feature is not enabled #641

merged 3 commits into from
Jan 18, 2021

Conversation

arubacao
Copy link
Contributor

The tests for DeleteAccountTest are always executed. Therefore tests fail when Account Deletion Features are disabled.

With this PR DeleteAccountTests are skipped when the feature is deactivated.

Screenshot 2021-01-18 at 16 39 07

@taylorotwell taylorotwell merged commit 56271e6 into laravel:2.x Jan 18, 2021
@driesvints
Copy link
Member

Just delete the tests if you don't need them.

@arubacao
Copy link
Contributor Author

I delete all tests that I don't need. This PR just makes the stubs more consistent.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants