Reduce amount of queries for Teams feature #708
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Comment on lines
+45
to
+47
| $request->user()->setRelation('currentTeam', $request->user()->allTeams()->filter(function ($team) use ($request) { | ||
| return $team->id === $request->user()->current_team_id; | ||
| })->first()); |
There was a problem hiding this comment.
Hi,
I think that PR cause a bug due to current_team_id field who can be null. Just try to install a fresh Laravel with Jetstream and you're unable to login (white page due to JS error and team).
It's because field is refresh with switchTeam method. Before PR, currentTeam() was called and check that.
Maybe you can try that 👍
if (is_null($request->user()->current_team_id)) {
$request->user()->switchTeam($request->user()->personalTeam());
}
driesvints
added a commit
that referenced
this pull request
Mar 25, 2021
This reverts commit 8028279.
|
@lexdewilligen this broke login/registration for Inertia, see #708 (comment) I've reverted this and tagged a new release. Next time, please try to test you change thoroughly before sending this in. |
|
@driesvints I did test it thoroughly, but I must have missed it! I'm very sorry this has happened! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The inertia middleware which is used to share data to the frontend currently runs 3 queries to load all teams and the current team.
However, this PR removes the last query since the currentTeam is one of the teams that's loaded in allTeams. This might just be a slight performance improvement! I hope it's worth merging into Jetstream.