Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[2.x] Add a tag dropdown link #711

Merged
merged 1 commit into from
Mar 18, 2021
Merged

[2.x] Add a tag dropdown link #711

merged 1 commit into from
Mar 18, 2021

Conversation

dillingham
Copy link
Contributor

PR adds <a> tag to the <jet-dropdown-link> component.

When adding spark billing, it would be cleaner to:

<jet-dropdown-link as="a" :href="route('spark.portal')">
    Billing
</jet-dropdown-link>

compared to manually adding the tailwind classes to <a> to avoid inertia navigation.

<a :href="route('spark.portal')" class="block px-4 py-2 text-sm leading-5 text-gray-700 hover:bg-gray-100 focus:outline-none focus:bg-gray-100 transition duration-150 ease-in-out">
    Billing
</a>

Used as="a" to stay in line with as="button"

@driesvints driesvints changed the title Add a tag dropdown link [2.x] Add a tag dropdown link Mar 18, 2021
@driesvints
Copy link
Member

as="link" might be more descriptive?

@taylorotwell
Copy link
Member

@driesvints it's an inertia-link by default so as=link might sound like inertia link.

@taylorotwell taylorotwell merged commit bde56ba into laravel:2.x Mar 18, 2021
@dillingham dillingham deleted the patch-1 branch March 18, 2021 19:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants