-
Notifications
You must be signed in to change notification settings - Fork 824
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[2.x] Made sure that the current session is destroyed when deleting your ac… #742
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…count (both in Inertia and Livewire)
driesvints
changed the title
Made sure that the current session is destroyed when deleting your ac…
[2.x] Made sure that the current session is destroyed when deleting your ac…
Mar 31, 2021
@Loots-it PR's without any explanation usually get closed (see the PR template when you open a PR). Please add a thorough explanation what this fixes and don't just link to an issue. Thanks. |
@driesvints I will make sure I do this in the future! |
This breaks a test in livewire stub.
PHPUnit Pretty Result Printer 0.30.1 by Codedungeon and contributors. ==> Configuration: ~/Projects/dev-menus/phpunit-printer.yml PHPUnit 9.5.4 by Sebastian Bergmann and contributors. ==> ExampleTest ✔ ==> ApiTokenPermissionsTest ✔ ==> AuthenticationTest ✔ ✔ ✔ ==> BrowserSessionsTest ✔ ==> CreateApiTokenTest ✔ ==> DeleteAccountTest ⚈ ✔ ==> DeleteApiTokenTest ✔ ==> EmailVerificationTest ⇢ ⇢ ⇢ ==> ExampleTest ✔ ==> PasswordConfirmationTest ✔ ✔ ✔ ==> PasswordResetTest ✔ ✔ ✔ ✔ ==> ProfileInformationTest ✔ ✔ ==> RegistrationTest ✔ ✔ ==> ...nticationSettingsTest ✔ ✔ ✔ ==> UpdatePasswordTest ✔ ✔ ✔ Time: 00:01.551, Memory: 50.50 MB ✖ There was 1 error: 1) Tests\Feature\DeleteAccountTest::test_user_accounts_can_be_deleted RuntimeException: Session store not set on request. /.../jetstream-dem/vendor/laravel/framework/src/Illuminate/Http/Request.php:483 /.../jetstream-demo/vendor/laravel/jetstream/src/Http/Livewire/DeleteUserForm.php:67 /.../jetstream-demo/vendor/laravel/framework/src/Illuminate/Container/BoundMethod.php:36 /.../jetstream-demo/vendor/laravel/framework/src/Illuminate/Container/Util.php:40 /.../jetstream-demo/vendor/laravel/framework/src/Illuminate/Container/BoundMethod.php:93 /.../jetsream-demo/vendor/laravel/framework/src/Illuminate/Container/BoundMethod.php:37 /.../jetsream-demo/vendor/livewire/livewire/src/ComponentConcerns/HandlesActions.php:149 /.../jetstream-demo/vendor/livewire/livewire/src/HydrationMiddleware/PerformActionCalls.php:35 /.../jetstream-demo/vendor/livewire/livewire/src/LifecycleManager.php:82 /.../jetstream-demo/vendor/livewire/livewire/src/Connection/ConnectionHandler.php:12 /.../jetstream-demo/vendor/livewire/livewire/src/Controllers/HttpConnectionHandler.php:20 /.../jetstream-demo/vendor/laravel/framework/src/Illuminate/Routing/ControllerDispatcher.php:48 /.../jetstream-demo/vendor/laravel/framework/src/Illuminate/Routing/Route.php:254 /.../jetstream-demo/vendor/laravel/framework/src/Illuminate/Routing/Route.php:197 /.../jetstream-demo/vendor/laravel/framework/src/Illuminate/Routing/Router.php:695 /.../jetstream-demo/vendor/laravel/framework/src/Illuminate/Pipeline/Pipeline.php:128 /.../jetstream-demo/vendor/laravel/framework/src/Illuminate/Pipeline/Pipeline.php:103 /.../jetstream-demo/vendor/laravel/framework/src/Illuminate/Routing/Router.php:697 /.../jetstream-demo/vendor/laravel/framework/src/Illuminate/Routing/Router.php:672 /.../jetstream-demo/vendor/laravel/framework/src/Illuminate/Routing/Router.php:636 /.../jetstream-demo/vendor/laravel/framework/src/Illuminate/Routing/Router.php:625 /.../jetstream-demo/vendor/laravel/framework/src/Illuminate/Foundation/Http/Kernel.php:166 /.../jetstream-demo/vendor/laravel/framework/src/Illuminate/Pipeline/Pipeline.php:128 /.../jetstream-demo/vendor/laravel/framework/src/Illuminate/Pipeline/Pipeline.php:103 /.../jetstream-demo/vendor/laravel/framework/src/Illuminate/Foundation/Http/Kernel.php:141 /.../jetstream-demo/vendor/laravel/framework/src/Illuminate/Foundation/Http/Kernel.php:110 /.../jetstream-demo/vendor/laravel/framework/src/Illuminate/Foundation/Testing/Concerns/MakesHttpRequests.php:508 /.../jetstream-demo/vendor/livewire/livewire/src/Testing/TestableLivewire.php:190 /.../jetstream-demo/vendor/livewire/livewire/src/Testing/MakesHttpRequestsWrapper.php:29 /...jetstream-demo/vendor/livewire/livewire/src/Testing/TestableLivewire.php:191 /...jetstream-demo/vendor/livewire/livewire/src/Testing/TestableLivewire.php:175 /.../jetstream-demo/vendor/livewire/livewire/src/Testing/Concerns/MakesCallsToComponent.php:134 /.../jetstream-demo/vendor/livewire/livewire/src/Testing/Concerns/MakesCallsToComponent.php:36 /...jetstream-demo/vendor/livewire/livewire/src/Testing/Concerns/MakesCallsToComponent.php:30 /.../jetstream-demo/tests/Feature/DeleteAccountTest.php:26 ERRORS! Errors: 1, Skipped: 3. |
This was referenced Apr 6, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#730