Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[2.x] Use correct feature flag in password reset tests #881

Merged
merged 2 commits into from
Sep 13, 2021
Merged

[2.x] Use correct feature flag in password reset tests #881

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
8983160
use correct feature flag in password reset tests
Sep 13, 2021
6cdf4ad
apply fixes to phpunit tests
Sep 13, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 4 additions & 4 deletions stubs/pest-tests/PasswordResetTest.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -10,7 +10,7 @@

$response->assertStatus(200);
})->skip(function () {
return ! Features::enabled(Features::updatePasswords());
return ! Features::enabled(Features::resetPasswords());
}, 'Password updates are not enabled.');

test('reset password link can be requested', function () {
Expand All @@ -24,7 +24,7 @@

Notification::assertSentTo($user, ResetPassword::class);
})->skip(function () {
return ! Features::enabled(Features::updatePasswords());
return ! Features::enabled(Features::resetPasswords());
}, 'Password updates are not enabled.');

test('reset password screen can be rendered', function () {
Expand All @@ -44,7 +44,7 @@
return true;
});
})->skip(function () {
return ! Features::enabled(Features::updatePasswords());
return ! Features::enabled(Features::resetPasswords());
}, 'Password updates are not enabled.');

test('password can be reset with valid token', function () {
Expand All @@ -69,5 +69,5 @@
return true;
});
})->skip(function () {
return ! Features::enabled(Features::updatePasswords());
return ! Features::enabled(Features::resetPasswords());
}, 'Password updates are not enabled.');
8 changes: 4 additions & 4 deletions stubs/tests/PasswordResetTest.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -15,7 +15,7 @@ class PasswordResetTest extends TestCase

public function test_reset_password_link_screen_can_be_rendered()
{
if (! Features::enabled(Features::updatePasswords())) {
if (! Features::enabled(Features::resetPasswords())) {
return $this->markTestSkipped('Password updates are not enabled.');
}

Expand All @@ -26,7 +26,7 @@ public function test_reset_password_link_screen_can_be_rendered()

public function test_reset_password_link_can_be_requested()
{
if (! Features::enabled(Features::updatePasswords())) {
if (! Features::enabled(Features::resetPasswords())) {
return $this->markTestSkipped('Password updates are not enabled.');
}

Expand All @@ -43,7 +43,7 @@ public function test_reset_password_link_can_be_requested()

public function test_reset_password_screen_can_be_rendered()
{
if (! Features::enabled(Features::updatePasswords())) {
if (! Features::enabled(Features::resetPasswords())) {
return $this->markTestSkipped('Password updates are not enabled.');
}

Expand All @@ -66,7 +66,7 @@ public function test_reset_password_screen_can_be_rendered()

public function test_password_can_be_reset_with_valid_token()
{
if (! Features::enabled(Features::updatePasswords())) {
if (! Features::enabled(Features::resetPasswords())) {
return $this->markTestSkipped('Password updates are not enabled.');
}

Expand Down