Show 'Unknown' instead of 'false' if other browser session Useragent details are not matched in library #934
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…details are not matched in library
…details are not matched in library (Livewire)
GeoSot
pushed a commit
to GeoSot/jetstream
that referenced
this pull request
Jan 27, 2022
…details are not matched in library (laravel#934) * Show 'Unknown' instead of 'false' if other browser session useragent details are not matched in library * Show 'Unknown' instead of 'false' if other browser session useragent details are not matched in library (Livewire)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request fixes an incorrect behavior of the 'Logout Other Browser Sessions' session list. If any of the browser's details are not matched in the jenssegers/agent library, currently it is displayed as 'false,' directly showing the output of the library which intentionally returns false if there is no match.
This pull request changes this to show as 'Unknown.' This seems a suitable term, as it is searching known browsers.
As requested in the contribution guide, I made this change in both Inertia and Livewire.
Screenshot before
Screenshot after