Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[8.x] Fix PHP 8.1 return type #969

Merged
merged 3 commits into from
Jan 27, 2022
Merged

[8.x] Fix PHP 8.1 return type #969

merged 3 commits into from
Jan 27, 2022

Conversation

driesvints
Copy link
Member

@driesvints driesvints commented Jan 27, 2022

Fixes #968

I'm a bit baffled that I couldn't reproduce this. No matter what I tried I couldn't trigger the error they experiencing while clearly this indeed is an issue. There's something that's hard-suppressing deprecation notices but I don't know what...

@driesvints driesvints changed the title Fix PHP 8.1 return type [8.x] Fix PHP 8.1 return type Jan 27, 2022
@driesvints driesvints marked this pull request as ready for review January 27, 2022 09:08
@taylorotwell taylorotwell merged commit 6c607ee into 2.x Jan 27, 2022
@taylorotwell taylorotwell deleted the fix-php81-issue branch January 27, 2022 17:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

PHP8.1 support
2 participants