Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Install command find the path to the php binary used #976

Merged
merged 3 commits into from
Feb 10, 2022

Conversation

Yi-pixel
Copy link
Contributor

When I have multiple php versions, when trying to differentiate them using different aliases like php(7.1), php74, php81, now when I execute php81 artisan jetstream:install livewire in CLI , here will be unexpectedly fallback to php(7.1) execution, which will fail.

Now he will correctly get the php81 I am using

I'm not sure how to write a test case for this modification, but it works for me, and I installed it by modifying the project's composer.json.

    "repositories": [
        {
            "type": "path",
            "url": "C:\\web\\server\\laravel\\jetstream"
        }
    ],

When I have multiple php versions, when trying to differentiate them using different aliases like `php`(7.1), `php74`, `php81`, now when I execute `php81 artisan jet
stream:install livewire` in CLI , here will be unexpectedly fallback to `php`(7.1) execution, which will fail.

Now he will correctly get the `php81` I am using
@Yi-pixel
Copy link
Contributor Author

The methods on the Application object can also be used here: $this->getApplication()->phpBinary()

@taylorotwell taylorotwell merged commit 2bd67c5 into laravel:2.x Feb 10, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants