HasTeams.php: make belongsToTeam accept null team #986
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This will allow users to pass a null value into belongsToTeam and have it return false instead of blowing up
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This will allow users to pass a null value into belongsToTeam and have it return false instead of blowing up, similarly to ownsTeam.
It makes intuitive sense that if you were to Find() a team, for example, and it came back null, you could pass that in and simply get the response back that you do not belong to the team since it does not exist.
In my case, teams are able to have nullable parentTeam's, so for my policy I would like to be able to simply pass:
can view: $user->belongsToTeam($user->currentTeam->parentTeam)It would allow me to write more elegant code than wrapping all of these in a check for if they're null or not.