[9.x] Client credentials middleware should allow any valid client (#1125) #1132
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
driesvints
changed the title
driesvints
approved these changes
Dec 3, 2019
tomjamon
added a commit
to tomjamon/passport
that referenced
this pull request
May 4, 2020
Last december a change was made to allow any valid client : Based on the theory and official standards of OAuth2: "The Client Credentials grant is used when applications request an access token to access their own resources, not on behalf of a user." (REF1, REF2). Shouldn't this change be persistant ? (taylorotwell merged commit on 5 Dec 2019) Ref laravel#1125 laravel#1132
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This commit "revert" Passport to its regular behavior where the client.credentials middleware only determines if the received access token is valid, which is only possible when the client credentials are correct, independently of the type of the client or even the type of the access token itself.
This was already discussed on this issue (#1125).