[10.x] Allow to pass Arrayable to whereIn
and whereNotIn
queries
#905
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
One annoyance that we often have and where the ecosystem doesn't feel cohesive throughout, is when adding search to an existing query and it suddenly stops working because of a collection being passed to
whereIn
orwhereNotIn
.Existing query without Scout
Adding Scout...
Before change
After change
I don't like that I had to remove a type declaration, but by looking at other classes (1, 2) this seems to be the way to go.