Add the Ability to Pass Custom ignore_paths
To Query Watcher
#1276
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
The "file" portion of the Query Watcher is unhelpful if you extend certain classes (e.g.
MySqlConnection.php
) since that adds a persistent layer to the stack trace.Solution
One easy fix for this is to allow folks to specify any extra files they want excluded from the stack trace like so:
(which fixes the above problem)
Where are the tests?
tests/Watchers/QueryWatcherTest.php
doesn't try testing'file'
and there isn't a test file forFetchesStackTrace.php
. I'm happy to take a go at adding some upon request if this solution seems acceptable. If not, let me know what solution you have in mind.