Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[0.x] Documentation updates #35

Merged
merged 9 commits into from
Jun 29, 2022
Merged

[0.x] Documentation updates #35

merged 9 commits into from
Jun 29, 2022

Conversation

jessarcher
Copy link
Member

@jessarcher jessarcher commented Jun 29, 2022 •
edited
Loading

This PR updates the migration guide as follows:

  • Adds semi-colons to example code to be consistent with laravel/laravel
  • Adds a section on updating the test helpers (withoutMix() -> withoutVite())
  • Adds a section on migrating Mix aliases.

It also adds a link to the official documentation in the README.

timacdonald
timacdonald approved these changes Jun 29, 2022
View reviewed changes
Copy link
Member

@timacdonald timacdonald left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

"Looks good to me";

jessarcher
jessarcher commented Jun 29, 2022
View reviewed changes
UPGRADE.md Outdated Show resolved Hide resolved
UPGRADE.md Outdated Show resolved Hide resolved
@jessarcher jessarcher mentioned this pull request Jun 29, 2022
Closed
@jessarcher jessarcher changed the title Migration guide updates Documentation updates Jun 29, 2022
@jessarcher jessarcher changed the title Documentation updates [0.x] Documentation updates Jun 29, 2022
timacdonald and others added 3 commits June 29, 2022 15:21
@taylorotwell taylorotwell merged commit 37ec798 into main Jun 29, 2022
@taylorotwell taylorotwell deleted the upgrade-updates branch June 29, 2022 15:03
timacdonald added a commit that referenced this pull request Jul 14, 2022
@jessarcher @timacdonald @taylorotwell
[0.x] Documentation updates (#35)
1a72ef9 
* Update semi-colon usage in examples

* Add section on test helpers

* add note about leading slashes in aliases

* remove additional alias

* improve wording

* Add documentation link to README

* Update UPGRADE.md

Co-authored-by: Jess Archer <[email protected]>

* Update UPGRADE.md

Co-authored-by: Jess Archer <[email protected]>

* Update UPGRADE.md

Co-authored-by: Tim MacDonald <[email protected]>
Co-authored-by: Taylor Otwell <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@timacdonald timacdonald timacdonald approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@jessarcher @timacdonald @taylorotwell