View Actions for History panel #17
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This name is shorter, easier to reason around (couldn't decide between) calling things "recent" or "recents"), and reflects what Spotify shows in their official clients.
Tracks in a TreeView have no children, so there is nothing to implement.
The commands contribution point is only needed for user-facing commands accessible via the Command Palette. The internal actions for track play/ pause are useless to the end user, so remove them.
This reverts commit f41c3a1.
The Spotify Web API does not allow getting track history with both after and before cursors set. after is used for getting newer history entries and before is used for older history entries. This requires two ways of updating the HistoryProvider track cache, so the logic was moved out of the getChildren() function and into loadNewTracks(). getChildren() now just returns the track cache.
This is done with the magic of setting Track.contextValue to "track" and then showing actions when "viewItem == track"
Shout-out to Kshitijaa for showing me that 1) This is possible 2) This is cool and epic encapsulation
larkinds
approved these changes
Feb 18, 2021
larkinds
reviewed
Feb 18, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves #8 and partially addresses #14
Actions:
Miscellaneous: