Cart page #19
Cart page #19
Conversation
client/src/components/Button.tsx
Outdated
| @@ -0,0 +1,3 @@ | |||
| export default function Button({ action, children }) { | |||
There was a problem hiding this comment.
Great job with the Cart modal - everything is neat so far and works as expected! However, one small comment I have is regarding the component props here and in the Modal component. Since we are using TypeScript, maybe it would be good to also show the types of passed props because without it they implicitly have a type of 'any'. Details on this page.
client/src/components/Modal.tsx
Outdated
| @@ -0,0 +1,20 @@ | |||
| import { useEffect, useRef } from "react"; | |||
|
|
|||
| export default function Modal({ onClose, isOpen, children }) { | |||
There was a problem hiding this comment.
Reminder to define the types of the props that you're importing
client/src/components/Modal.tsx
Outdated
| <dialog ref={modalRef} className={className}> | ||
| <button | ||
| onClick={onClose} | ||
| style={{ |
There was a problem hiding this comment.
I tend to keep my inline styles to less than 3 - what do you think of using that as our standard for the project, and moving these styles into a css file?
There was a problem hiding this comment.
moving these still out of here and passing the classes in as a prop instead.
|
@larkinds I think I've addressed all your requested changes. If there's nothing else, could you please approve this so I can merge this PR? |
client/src/pages/cart/CartBtn.tsx
Outdated
There was a problem hiding this comment.
Oh my gosh, this icon is so cute!
cart component with quantity counter and remove button for each item in the cart.
Covered issues: #2 #1 #3 #4 #6 #7 #24