Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Single page #86

Open
wants to merge 11 commits into
base: staging
Choose a base branch
from
Open

Single page #86

wants to merge 11 commits into from

Conversation

jgesel
Copy link
Collaborator

@jgesel jgesel commented Oct 18, 2023

this PR includes
#63
#80
#56 (handled by Clerk and not localStorage)

@larkinds
Copy link
Owner

Could you please add references to the relevant issues that this addresses in your description?

Copy link
Owner

@larkinds larkinds left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Big lift, wow! Good job.

I've made a few comments and requests for changes throughout. One item left over is that that the following error is popping up in the browser's console.

Screen Shot 2023-10-23 at 5 08 59 PM

client/src/Components/LogIn.tsx Outdated Show resolved Hide resolved
client/src/pages/home/HomePage.tsx Show resolved Hide resolved
client/src/pages/home/HomePage.tsx Show resolved Hide resolved
client/src/services/icecreams.ts Outdated Show resolved Hide resolved
client/src/pages/home/HomePage.tsx Outdated Show resolved Hide resolved
client/src/pages/flavor_page/FlavorPage.tsx Outdated Show resolved Hide resolved
@eyeriss42
Copy link
Collaborator

One item left over is that that the following error is popping up in the browser's console.

Josh and I checked and we can't see this error, could you please double check if you still see it?

@eyeriss42
Copy link
Collaborator

Could you please add references to the relevant issues that this addresses in your description?

we added the issue numbers, thank you!

@eyeriss42
Copy link
Collaborator

Could you please add references to the relevant issues that this addresses in your description?

resolved thank you

@eyeriss42 eyeriss42 requested a review from larkinds November 22, 2023 16:15
Copy link
Owner

@larkinds larkinds left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good work Iris!
I'm adding a ticket about error handling, and have included notes on it here. Feel free to merge this in without making the edits, or make the edits here. Either way works!

server/controllers/halloffame.ts Show resolved Hide resolved
server/controllers/halloffame.ts Show resolved Hide resolved
server/controllers/images.ts Show resolved Hide resolved
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants