FlxGroup: fix splice remove() not decreasing length

closes HaxeFlixel#2010
larsiusprime · Apr 17, 2018 · eb9356d · eb9356d
1 parent 50e813a
commit eb9356d
Show file tree

Hide file tree

Showing 2 changed files with 25 additions and 0 deletions.
diff --git a/flixel/group/FlxGroup.hx b/flixel/group/FlxGroup.hx
@@ -345,7 +345,10 @@ class FlxTypedGroup<T:FlxBasic> extends FlxBasic
 			return null;
 
 		if (Splice)
+		{
 			members.splice(index, 1);
+			length--;
+		}
 		else
 			members[index] = null;
 

diff --git a/tests/unit/src/flixel/group/FlxGroupTest.hx b/tests/unit/src/flixel/group/FlxGroupTest.hx
@@ -152,4 +152,26 @@ class FlxGroupTest extends FlxTest
 		Assert.areEqual(group.length, group.countLiving());
 		Assert.areEqual(0, group.countDead());
 	}
+
+	@Test // #2010
+	function testRemoveSplice()
+	{
+		var group = new FlxGroup();
+		group.add(new FlxBasic());
+		Assert.areEqual(1, group.length);
+
+		group.remove(group.members[0], true);
+		Assert.areEqual(0, group.length);
+	}
+
+	function testRemoveNoSplice()
+	{
+		var group = new FlxGroup();
+		group.add(new FlxBasic());
+		Assert.areEqual(1, group.length);
+
+		group.remove(group.members[0], false);
+		Assert.areEqual(1, group.length);
+		Assert.isNull(group.members[0]);
+	}
 }