Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

bug fixes #17

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

bug fixes #17

wants to merge 2 commits into from

Conversation

MarsAuthority
Copy link

  1. If function's parameter is ref, taint doesn't work.
  2. Mysqli bug fix.

@MarsAuthority
bug fixes
942f2a9 
1. If function's parameter is ref, taint false.
2.Mysqli bug gix.
laruence
laruence reviewed Nov 17, 2014
View reviewed changes
taint.c
zval *ret;
ALLOC_ZVAL(ret);
INIT_PZVAL_COPY(ret, *op1);
zval_copy_ctor(ret);
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

这块并没有给新得到的zval分配taint标记啊?

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

不好意思，这块忘了，一会儿加上。

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

之前上传的未同步...现在的刚刚测试了没问题，麻烦鸟哥看看。

@laruence laruence added the Bug label Jul 24, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
Bug
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@MarsAuthority @laruence