Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add support for nested file paths in latch metadata #381

Merged
merged 24 commits into from
Jan 27, 2024

Conversation

rahuldesai1
Copy link
Contributor

@rahuldesai1 rahuldesai1 commented Jan 25, 2024

The purpose of this is to support nested file paths in the generate-metadata command.

The interface is a bit more complicated; however, this allows users to be able to upload Snakemake workflows without having to make any modifications to their config.yaml (which can sometimes be quite large).

Not planning on merging until docs are updated.

latch/types/metadata.py Outdated Show resolved Hide resolved
latch/types/metadata.py Outdated Show resolved Hide resolved
latch/types/metadata.py Outdated Show resolved Hide resolved
latch/types/metadata.py Outdated Show resolved Hide resolved
latch_cli/snakemake/workflow.py Outdated Show resolved Hide resolved
latch_cli/snakemake/workflow.py Show resolved Hide resolved
latch_cli/snakemake/workflow.py Outdated Show resolved Hide resolved
latch_cli/snakemake/workflow.py Outdated Show resolved Hide resolved
latch/types/metadata.py Outdated Show resolved Hide resolved
latch_cli/snakemake/config/parser.py Outdated Show resolved Hide resolved
latch_cli/snakemake/config/parser.py Outdated Show resolved Hide resolved
latch_cli/snakemake/config/parser.py Outdated Show resolved Hide resolved
latch_cli/snakemake/config/parser.py Show resolved Hide resolved
latch_cli/snakemake/workflow.py Outdated Show resolved Hide resolved
latch_cli/snakemake/workflow.py Outdated Show resolved Hide resolved
latch_cli/snakemake/workflow.py Outdated Show resolved Hide resolved
latch_cli/snakemake/workflow.py Outdated Show resolved Hide resolved
latch_cli/snakemake/workflow.py Outdated Show resolved Hide resolved
latch/types/metadata.py Outdated Show resolved Hide resolved
latch/types/metadata.py Outdated Show resolved Hide resolved
latch_cli/snakemake/config/utils.py Outdated Show resolved Hide resolved
latch_cli/snakemake/config/utils.py Outdated Show resolved Hide resolved
latch_cli/snakemake/config/utils.py Outdated Show resolved Hide resolved
latch_cli/snakemake/config/utils.py Outdated Show resolved Hide resolved
latch_cli/snakemake/workflow.py Outdated Show resolved Hide resolved
latch_cli/snakemake/workflow.py Outdated Show resolved Hide resolved
Copy link
Contributor

@ayushkamat ayushkamat left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

kinda strange that the type validation we're doing here doesn't support general unions and handles optionals as an edge case tbh, but its not a big deal for now

latch/types/metadata.py Outdated Show resolved Hide resolved
latch/types/metadata.py Outdated Show resolved Hide resolved
@rahuldesai1 rahuldesai1 merged commit 1ce8761 into main Jan 27, 2024
10 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants