create temp dir and use it for session dir in tests #335
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
To avoid delete a session file that this repository created in CI.
ninjinkun
reviewed
Nov 12, 2021
| @@ -48,6 +51,7 @@ def setUp(self): | |||
|
|
|||
| def tearDown(self): | |||
| clean_session_files() | |||
| del os.environ[SESSION_DIR_KEY] | |||
There was a problem hiding this comment.
With tempfile.mkdtemp, you need to clean up the temp directory manually https://stackoverflow.com/questions/6884991/how-to-delete-a-directory-created-with-tempfile-mkdtemp/55871731
Konboi
force-pushed
the
fix-extra-session
branch
2 times, most recently
from
c844dbc to
340de21
Compare
Konboi
force-pushed
the
fix-extra-session
branch
from
340de21 to
e2e8481
Compare
|
Kudos, SonarCloud Quality Gate passed!
|
ninjinkun
approved these changes
Nov 17, 2021
Konboi
commented
Nov 17, 2021
| if: matrix.python-version == '3.6' | ||
| run: | | ||
| python -m pip install --upgrade pip | ||
| pip install pipenv==2021.11.5 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A session file that was created in this repo's CI was deleted by tests (by clean_test_session_files method)
Then, two test sessions were created 1) subset command, 2) record test command but it's not intented.
So I create a temp dir and use it in test to avoid deleting a session file that this repository created in CI.