add X-LaunchDarkly-Payload-ID and Cache-Control to allowable CORS hea…

…ders for JS (#112)
launchdarkly · Jan 15, 2020 · d0605f9 · d0605f9
1 parent 3d7e7e1
commit d0605f9
Show file tree

Hide file tree

Showing 2 changed files with 4 additions and 1 deletion.
diff --git a/client-side.go b/client-side.go
@@ -60,10 +60,13 @@ func (m clientSideMux) getGoals(w http.ResponseWriter, req *http.Request) {
 }
 
 var allowedHeadersList = []string{
+	"Cache-Control",
 	"Content-Type",
 	"Content-Length",
 	"Accept-Encoding",
 	"X-LaunchDarkly-User-Agent",
+	"X-LaunchDarkly-Payload-ID",
+	"X-LaunchDarkly-Wrapper",
 	events.EventSchemaHeader,
 }
 

diff --git a/relay_test.go b/relay_test.go
@@ -205,7 +205,7 @@ func TestCorsMiddlewareSetsCorrectDefaultHeaders(t *testing.T) {
 		assert.Equal(t, w.Header().Get("Access-Control-Allow-Origin"), "*")
 		assert.Equal(t, w.Header().Get("Access-Control-Allow-Credentials"), "false")
 		assert.Equal(t, w.Header().Get("Access-Control-Max-Age"), "300")
-		assert.Equal(t, w.Header().Get("Access-Control-Allow-Headers"), "Content-Type,Content-Length,Accept-Encoding,X-LaunchDarkly-User-Agent,"+events.EventSchemaHeader)
+		assert.Equal(t, w.Header().Get("Access-Control-Allow-Headers"), "Cache-Control,Content-Type,Content-Length,Accept-Encoding,X-LaunchDarkly-User-Agent,X-LaunchDarkly-Payload-ID,X-LaunchDarkly-Wrapper,"+events.EventSchemaHeader)
 		assert.Equal(t, w.Header().Get("Access-Control-Expose-Headers"), "Date")
 	})).ServeHTTP(resp, req)
 }