Allow the in-memory cache TTL to be specified as a configuration parameter #11
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
drichelson
reviewed
Oct 24, 2016
| @@ -72,6 +73,8 @@ To set up LDR in this mode, provide a redis host and port, and supply a Redis ke | |||
| prefix = "ld:spree:test" | |||
| apiKey = "SPREE_TEST_API_KEY" | |||
|
|
|||
| You can also configure an in-memory cache for the relay to use so that connections do not always hit redis. To do this, set the `ttl` parameter in your `redis` configuration section to a number (in milliseconds). | |||
There was a problem hiding this comment.
I think we should have the in-memory cache's default TTL be > 0. Anyone running LD-Relay for scale reasons will likely want it enabled.
There was a problem hiding this comment.
Good idea-- addressed in latest commit.
drichelson
reviewed
Oct 24, 2016
| @@ -47,6 +49,7 @@ type Config struct { | |||
| Redis struct { | |||
| Host string | |||
| Port int | |||
| Ttl *int | |||
There was a problem hiding this comment.
I wonder if TTL here is misleading- it seems to suggest that this is the Redis TTL, not the in-memory cache's TTL..
There was a problem hiding this comment.
Mmm... true. Suggestions?
There was a problem hiding this comment.
but if it is consistent with how it is named in the RedisFeatureStore we should either leave it or change it in both places
|
closing, as this is not quite the right approach |
|
Sorry. I accidentally closed this. |
LaunchDarklyCI
pushed a commit
that referenced
this pull request
Oct 7, 2020
(v6 - #11) factor out application startup code
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.