Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update in-app README so that routes work as expected #134

Merged
merged 1 commit into from
Apr 8, 2021
Merged

Update in-app README so that routes work as expected #134

merged 1 commit into from
Apr 8, 2021

Conversation

simonkotwicz
Copy link
Contributor

closes #133

@eli-darkly
Copy link
Contributor

Thanks. Until you submitted this, I had completely forgotten that adding a path prefix of /relay was something that was in our example code, and not just something you had decided to do in your own application. I think we should probably update this to show examples both with and without a prefix, because not using one (and just putting the Relay endpoint on a different port from whatever other endpoints the application might have) may be a somewhat more common use case. But in the meantime this makes the current example less wrong.

@eli-darkly eli-darkly merged commit 8cb2243 into launchdarkly:v6 Apr 8, 2021
@simonkotwicz simonkotwicz deleted the patch-1 branch April 8, 2021 01:59
LaunchDarklyCI pushed a commit that referenced this pull request Apr 23, 2021
(v6 - #2) add type-based validation for duration settings
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Help with running ld-relay as part of an application
2 participants