fix empty response body when allowedOrigins is set #185
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
joshuaeilers
force-pushed
the
fix-allowed-origins-empty-response-body
branch
from
5933dec to
f329872
Compare
joshuaeilers
force-pushed
the
fix-allowed-origins-empty-response-body
branch
from
f329872 to
734f145
Compare
|
I'm not sure why the workflow is failing with 401's. Could someone from the LD team help me out with that? |
The integration test job requires a credential to connect to LD, and that credential is configured as a secret in CircleCI for our own projects - so I think it cannot work in a fork. In other words, this failure isn't related to your change. |
eli-darkly
approved these changes
Apr 29, 2022
Merged
|
We've released v6.7.6 with this fix - thanks again. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Requirements
Related issues
Provide links to any issues in this repository or elsewhere relating to this pull request.
Describe the solution you've provided
When setting the allowedOrigins to something other than
*, as in a real domain, we do not see any response body forGETrequests. This change stops the short-circuiting that was happening if an origin was matched.Describe alternatives you've considered
I thought about always passing
*in production as an absolute last resort.Additional context
Add any other context about the pull request here.