Add a "status" endpoint for health checks #3
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| type StatusEntry struct { | ||
| Status string `json:"status"` | ||
| } | ||
|
|
||
| var configFile string | ||
|
|
||
| func main() { |
There was a problem hiding this comment.
I got rid of the wait group, which allows the server to start before all of the environments have been initialized. This makes the whole system a little more resilient-- it can begin serving requests if (e.g.) one environment can't connect.
There was a problem hiding this comment.
What will happen if a connection comes in for an environment that is not yet initialized?
There was a problem hiding this comment.
The corresponding client won't yet be in the handler map, so you'll get a 404.
|
lgtm |
| @@ -101,7 +110,39 @@ func main() { | |||
| }(envName, *envConfig) | |||
| } | |||
|
|
|||
| wg.Wait() | |||
| http.Handle("/status", http.HandlerFunc(func(w http.ResponseWriter, req *http.Request) { | |||
There was a problem hiding this comment.
Do we want to make the port configurable? i assume it will be listening on port 80 by default..
There was a problem hiding this comment.
It is-- this isn't where that's handled though. See where the configuration port is usdd
|
👍 |
|
lgtm |
jkodumal
added a commit
that referenced
this pull request
May 25, 2017
…ld-have-a-default-port Add a default port, and check if no environments are specified.
LaunchDarklyCI
pushed a commit
that referenced
this pull request
Oct 7, 2020
(v6 - #3) move config types into new package, refactor, better separation from internal types
LaunchDarklyCI
pushed a commit
that referenced
this pull request
Oct 7, 2020
(v6 - #3) big refactoring of Relay tests
LaunchDarklyCI
pushed a commit
that referenced
this pull request
Oct 7, 2020
…oconf-stream (RPE - #3) implement auto-config stream client
LaunchDarklyCI
pushed a commit
that referenced
this pull request
Oct 7, 2020
(v6 - #3) add env key etc. to status in auto-config mode
LaunchDarklyCI
pushed a commit
that referenced
this pull request
Oct 7, 2020
LaunchDarklyCI
pushed a commit
that referenced
this pull request
Oct 7, 2020
(#3) move core/config to ./config, move core to internal/core, unify config types
LaunchDarklyReleaseBot
pushed a commit
that referenced
this pull request
Jul 21, 2021
(#3) only start big seg synchronizer if necessary
LaunchDarklyReleaseBot
added a commit
that referenced
this pull request
Mar 24, 2022
* fix data race * (offline mode #2) add configuration for offline mode (#199) * (offline mode #3) factor out types that are shared between autoconfig and filedata (#200) * add full integration test of Relay in standard config mode * add missing functions * also run database integrations test * better logging * even better logging * comments, misc cleanup * more logging + Docker helper improvements * (offline mode #4) full implementation of offline mode in Relay app (#202) * fix goroutine leak related to stream heartbeats * use correct import path for gcfg * use correct import path for gcfg * added whitesource to build * removed broken environment references from build * Updating the minimum go version in the contribution guidelines (#213) * change offline mode env schema to separate dataId from other properties * offline mode in-repo docs (#214) * (#6) offline mode integration test + offline mode fixes (#204) * only run scheduled tests on private repo (#216) * fix "expiring-but-still-valid SDK key" logic so requests with old key are accepted * add note about non-support for clustered Redis and Redis Sentinel * disable diagnostic events & metrics events in offline mode * add accept-events-but-discard-them behavior for offline mode * clean up imports * fix product name in docs * fix the broken images in our repo docs (#217) * in auto-config mode, return 503 for client requests till configuration is complete (#219) * always send stream updates to clients regardless of version checking (#224) * Enable hourly Relay integration tests against Production (#223) * Record response body when relay archive download test fails (#225) There is some additional information provided in the response body for certain 504 error codes and this should allow us to see it. * Fix the broken production integration tests (#226) * improve metrics documentation and fix route strings in docs (#227) * improve metrics documentation and fix route strings in docs * clarify mobile + browser terminology * use more efficient jsonstream encoding/decoding for stream data and evaluations (#228) * recognize alias events from non-v3-schema payloads and forward them unchanged * environment should still be usable even if the client timed out * bump dependency versions for SDK fixes * update go-server-sdk-dynamodb to get newer AWS SDK * minor clarification about Relay.Close (#234) * Use the Go releaser template (#233) * [ch102248] big segment sync with redis (#235) * fix makefile so it tries building all the test code first before running any of it (#239) * (big segments #1) add basic big segments configuration for SDK clients (#237) * (big segments #2) add more abstraction around big segments implementation for testability (#238) * [102253] bigsegment status / config (#242) * big segments integration test + misc fixes (#240) * use latest URL paths for big segments endpoints * add SDK DynamoDB integration for big segments (#241) * fix broken link in Markdown docs (#246) * make sure newly added credentials for existing environments are accepted in requests (#244) * don't return 503 if SDK initialization has timed out * add in-repo docs about error/503 behavior (#249) * [ch102255] BigSegments DynamoDB (#245) * add init timeout config option + better test coverage + misc refactoring (#250) * fix example build command * use public prerelease tags instead of private dependencies * fix Go installation in CI * update SDK dependencies for JSON number parsing bugfix * update gorilla/mux to 1.8.0 * update OpenCensus packages * add Go 1.16 CI + "latest Go" CI + use latest 1.15 patch for release * cimg images use "current", not "latest" * seems there isn't any cimg/go "latest" or "current" * add daily package build test in CI * job names * bump SDK version for traffic allocation feature * [ch113491] update alpine base image (#258) * use latest prerelease SDK * fix enabling of test tags in CI * add DynamoDB docker image in CI * set a polling base URI in end-to-end tests since big segments logic will use it * fix initialization logic so SDK client creation errors aren't lost when big segments are enabled * fix use of prefix key in DynamoDB + improve tests (#260) * more debug logging, less info logging for big segments logic * make logging of big segments patch version mismatch clearer and use Warn level * fix log parameter * fix DynamoDB updates for big segments metadata * add test to make sure sync time and cursor can be updated independently * only start big seg synchronizer if necessary * use SDK GA releases * change applyPatch to exit early on version mismatch; go back to restarting stream in this case * add unit tests for version mismatch behavior + DRY tests * add log assertion * fix retry logic on big segments stream failure * add more logging for big segments connection status * fix logging assertion * add more big segments integration tests * fix overly-time-sensitive file data tests * fix more flaky tests * run big segments tests with DynamoDB too * Migrate transitive dep (jwt-go) to use modern version without vulnerability. * Edit doc * move Relay release logic to .ldrelease script * suppress SDK big segments status query if we've never synced big segments * dump Relay logs including debug logs if integration test fails * include environment prefix in BigSegmentSynchronizer logging * increase big segment integration test timeout (#274) * generate client-side stream pings if big segments have changed * clear big segments cache as needed + simplify state management * fix tests and simplify component creation * use GA releases of SDK packages * disable CI package-build-test in Go 1.16+ * Migrate Relay release to Releaser v2 and support dry run (#278) * Adding degraded doc blurb for big segments (#280) * respect Redis password & TLS options for big segments; add Redis password integration tests * redact Redis URL password in logs and status resource * update go-server-sdk-redis-redigo to 1.2.1 for Redis URL logging fix * Part 1, add the config and the documentation for the new config * Part 2, Add the configuration validation and test * Part 3, the actual logic to include the headers in the CORS Access-Control-Allow-Headers * Linter * update Alpine version to 3.14.2 to fix openssl CVEs * Fix the global variable modification * Go format * turn off unnecessary metrics integrations in config for Docker smoke test * rename test.env to smoke-test.env to clarify what it's for * fix setting of custom Access-Control-Allow-Origin and add test (#285) * add more explanatory test output and more verbose debugging for big segments integration tests (#287) * update to Go 1.16.10 + Alpine 3.14.3; add some docs about releases (#288) * update go-server-sdk-consul version for Consul API version update * override x/crypto dependency version for CVE-2020-29652 * bump Prometheus dependency to eliminate jwt-go vulnerability * drop support for Go 1.14 & 1.15 * make sure defaults are always applied for base URL properties * rm unused * rm unnecessary linter directive * add separate configuration for server-side/client-side SDK base URLs & update the defaults * remove Whitesource CI job + remove obsolete dependency issue note * don't include any big segment status info in status resource unless that feature is active (#296) * don't include any big segment status info in status resource unless that feature is active * fix Big Segments staleness logic in status resource * documentation * update x/text package for vulnerability GO-2021-0113 * add Trivy security scan to CI (#297) * add daily re-scan with Trivy * update Go version to 1.17.6 (#301) * always terminate if auto-config stream fails with a fatal error * pass along tags header when proxying events * comments, rm debugging * fix auth header logic * fix auth header logic some more * comments * add tags header to CORS header whitelist (#304) * update to Alpine 3.14.4 for CVE-2022-0778 fix Co-authored-by: Eli Bishop <[email protected]> Co-authored-by: Patrick Kaeding <[email protected]> Co-authored-by: Ben Woskow <[email protected]> Co-authored-by: LaunchDarklyCI <[email protected]> Co-authored-by: Ben Woskow <[email protected]> Co-authored-by: Andrew Shannon Brown <[email protected]> Co-authored-by: hroederld <[email protected]> Co-authored-by: LaunchDarklyReleaseBot <[email protected]> Co-authored-by: Dan Richelson <[email protected]> Co-authored-by: Dan Richelson <[email protected]> Co-authored-by: Louis Chan <[email protected]> Co-authored-by: Louis Chan <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.