Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix missing tasks source #181

Merged
merged 44 commits into from
Jan 20, 2019
Merged

Fix missing tasks source #181

merged 44 commits into from
Jan 20, 2019

Conversation

PabloKowalczyk
Copy link
Collaborator

Q A
Fixed tickets #176

PR fixes issues related to config-file/tasks-source recognition based on Crunz-bin-relative paths. Now everything is related to cwd. In case user depends on old behavior deprecation messages will appear.

@PabloKowalczyk PabloKowalczyk added this to the v1.11 milestone Jan 19, 2019
kinoute
kinoute reviewed Jan 20, 2019
View reviewed changes
Copy link

@kinoute kinoute left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Maybe we could add an example in the UPGRADE.md file for the cronjob entry that needs to be changed with the use of cd as well:

* * * * * cd /path/to/project && vendor/bin/crunz schedule:run

Same for the README.md file (after 1.11 is released)

@PabloKowalczyk
Copy link
Collaborator Author

@kinoute nice catch, would you like to do full Code Review?

@PabloKowalczyk PabloKowalczyk changed the base branch from 1.x to 1.11.x January 20, 2019 11:12
@kinoute
Copy link

kinoute commented Jan 20, 2019

My knowledge is pretty limited but it looks solid, good job!

@PabloKowalczyk
Fix permissions on linux
fd6d9b2
@PabloKowalczyk
Merge double directory separator into one
f2ac6d4
@PabloKowalczyk
Add legacy source paths to configuration
28151b4
@PabloKowalczyk
Add missing CRUNZ_BIN_DIR
322411c
@PabloKowalczyk
Add NullLogger
3d480de
@PabloKowalczyk
Log realpath if exists
ba6dce5
@PabloKowalczyk
Add allLegacyPaths method
88687cb
@PabloKowalczyk
Fallback to legacy tasks source
9a21be3
@PabloKowalczyk
Add missing "tasks" segment
75cc7c2
@PabloKowalczyk
[WIP] legacy config loader
917b592
@PabloKowalczyk
Use configured "source" instead of "tasks" literal
d6770a6
@PabloKowalczyk
Fix returned path
2d847f6
@PabloKowalczyk
Introduce EndToEndTestCase
f2f2424
@PabloKowalczyk
Test config file recognition
74dcba2
@PabloKowalczyk
Add "fromStrings" named constructor to Path class
0161b77
@PabloKowalczyk
Require json extension in dev env
5f0c40d
@PabloKowalczyk
Source path fallback to "tasks" if "source" is not provided
1e3e762
@PabloKowalczyk
Upgrade dev tools
ad2148f
@PabloKowalczyk
CS fixes
a67634f
@PabloKowalczyk
Add "tempDir" method to FilesystemInterface
354c7f5
@PabloKowalczyk
Fix typo
27d8fca
@PabloKowalczyk
Add "removeDirectory" method to Filesystem
051d8a8
@PabloKowalczyk
Add "dumpFile" method to Filesystem
bc5da7c
@PabloKowalczyk
Unlink created file
592b161
@PabloKowalczyk
Add "createDirectory" method to Filesystem
bd100b6
@PabloKowalczyk
Add "copy" method to Filesystem
b698b1d
@PabloKowalczyk
Add "projectRootDirectory" to Filesystem
6c11b7d
@PabloKowalczyk
Do not create directory if it exists
2169c45
@PabloKowalczyk
Add $ignoredPaths param to "removeDirectory"
28f9f5f
@PabloKowalczyk
Add PhpVersionTask
1042489
@PabloKowalczyk
Add Environment and EnvironmentBuilder
91715bd
@PabloKowalczyk
Add createEnvironmentBuilder to EndToEnd test case
407429b
@PabloKowalczyk
Add TasksSourceRecognitionTest
769f1ca
@PabloKowalczyk
Remove duplicated test
1e2c38f
@PabloKowalczyk
[REFACTOR] Use new EnvironmentBuilder instead of pre created tests envs
0d0660b
@PabloKowalczyk
Add UPGRADE.md file
d05f891
@PabloKowalczyk
Fix Process deprecation about env inheriting
9ff5846
@PabloKowalczyk
Remove unused "createProcess" method
29ea09d
@PabloKowalczyk
Use "createProcess" with cwd
7b55cea
@PabloKowalczyk
Do not add PHP_BINARY on Windows
b328759
@PabloKowalczyk
Make ConfigurationTest OS-independent
179b2c9
@PabloKowalczyk
On Windows and Symfony below 3.2 do not rely on Process::setEnv, use …
065a0cf 
…"\putEnv" hack instead
@PabloKowalczyk
Add example Cron job
09db9f4
@PabloKowalczyk
Do not use root paths
2098100
@PabloKowalczyk PabloKowalczyk merged commit 654eb5f into lavary:1.11.x Jan 20, 2019
@PabloKowalczyk PabloKowalczyk deleted the fix-missing-tasks-source branch January 20, 2019 16:25
This was referenced Jan 20, 2019
Closed
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kinoute kinoute kinoute left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
v1.11
Development

Successfully merging this pull request may close these issues.
2 participants
@PabloKowalczyk @kinoute