Swap out the cron-expression package #240
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mareksuscak
changed the title
|
Not sure why appveyor's failing. Seems to be an internal issue. |
composer.json
Outdated
| @@ -26,9 +26,9 @@ | |||
| }, | |||
| "require": { | |||
| "php": "^7.2", | |||
| "dragonmantank/cron-expression": "^2.3", | |||
There was a problem hiding this comment.
Could you lower minimum required version to 2.0? Maybe, in the wild, someone can't update this package to 2.3 version for some reason and Crunz doesn't really need newest version.
|
AppVeryor's fail is completely unrelated to this PR, i will fix it in other PR, now just ignore it. |
mareksuscak
commented
Aug 10, 2019
|
Thanks @mareksuscak |
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
mtdowling/cron-expressionhas been deprecated in favor ofdragonmantank/cron-expressionaccording to the README. This PR replaces the deprecatedcron-expressionpackage for a maintained fork.Implementation notes
Seems to be a drop-in replacement.