Deprecate most "Event::every*" methods #344
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As discussed in #307 most
Task::every*()
methods are not really "every". TakeeveryFourtyMinutes
for example, expected run dates are:00:00
,00:40
,01:20
,02:00
, but actual dates are:00:00
,00:40
,01:00
,01:40
, so task doesn't run every fourty minutes (same rules applies to "hour", "day" and "moth" calls). To reduce ambigious behavior i decided to deprecate mostTask::every*()
methods and add/leave only real "every" methods likeeveryTenMinutes
oreveryThirtyMinutes
.With this change IDE can autocomplete "new" methods, which is not a case earlier.
Migration path is not complex, use one of "new" methods or provide Cron expression by
Task::cron
method."New" methods:
everyMinute
everyTwoMinutes
everyThreeMinutes
everyFourMinutes
everyFiveMinutes
everyTenMinutes
everyFifteenMinutes
everyThirtyMinutes
everyTwoHours
everyThreeHours
everyFourHours
everySixHours