Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Return CPICashFlow base date if available #1280

Merged
merged 2 commits into from
Jan 3, 2022

Conversation

hsegger
Copy link
Contributor

@hsegger hsegger commented Jan 3, 2022

this is the draft of the code change

@boring-cyborg
Copy link

boring-cyborg bot commented Jan 3, 2022

Thanks for opening this pull request! It might take a while before we look at it, so don't worry if there seems to be no feedback. We'll get to it.

@CLAassistant
Copy link

CLAassistant commented Jan 3, 2022

CLA assistant check
All committers have signed the CLA.

@hsegger hsegger mentioned this pull request Jan 3, 2022
@lballabio lballabio linked an issue Jan 3, 2022 that may be closed by this pull request
@lballabio lballabio changed the title #1247 return baseDate if available Return CPICashFlow base date if available Jan 3, 2022
@lballabio lballabio changed the title Return CPICashFlow base date if available Return CPICashFlow base date if available Jan 3, 2022
omit double call

Co-authored-by: Luigi Ballabio <[email protected]>
@lballabio
Copy link
Owner

Thanks! May you also check the CLAssistant comment above?

@hsegger
Copy link
Contributor Author

hsegger commented Jan 3, 2022

Thanks! May you also check the CLAssistant comment above?

Done. Sorry, I am new to the procedure.

@lballabio
Copy link
Owner

No problem. That just needs to be done once.

@coveralls
Copy link

Coverage Status

Coverage decreased (-0.002%) to 70.963% when pulling 088b73e on hsegger:1247_baseDate into 1bcc723 on lballabio:master.

@lballabio lballabio merged commit 3000af0 into lballabio:master Jan 3, 2022
@boring-cyborg
Copy link

boring-cyborg bot commented Jan 3, 2022

Congratulations on your first merged pull request!

@lballabio lballabio added this to the 1.25 release milestone Jan 3, 2022
@hsegger hsegger deleted the 1247_baseDate branch January 3, 2022 16:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

CPICashFlow::baseDate()
4 participants