Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update Australian calendar #1374

Merged
merged 1 commit into from
May 9, 2022

Conversation

pradkrish
Copy link
Contributor

Fixes #1365 and #1366

@boring-cyborg
Copy link

boring-cyborg bot commented May 8, 2022

Thanks for opening this pull request! It might take a while before we look at it, so don't worry if there seems to be no feedback. We'll get to it.

@CLAassistant
Copy link

CLAassistant commented May 8, 2022

CLA assistant check
All committers have signed the CLA.

@coveralls
Copy link

Coverage Status

Coverage remained the same at 71.105% when pulling a2d6562 on pradkrish:pk/update-Oz-calendar into 30121a0 on lballabio:master.

@lballabio lballabio linked an issue May 9, 2022 that may be closed by this pull request
@lballabio lballabio added this to the Release 1.27 milestone May 9, 2022
@lballabio lballabio merged commit 6d46a15 into lballabio:master May 9, 2022
@boring-cyborg
Copy link

boring-cyborg bot commented May 9, 2022

Congratulations on your first merged pull request!

@lballabio lballabio changed the title update australia calendar Update Australian calendar May 9, 2022
@klin333
Copy link
Contributor

klin333 commented May 10, 2022

not sure if the new year's day change is right, maybe it should be this instead?

// New Year's Day (possibly moved to Monday)
|| ((d == 1 || ((d == 2 || d == 3) && w == Monday)) && m == January)

@gbfredrik
Copy link
Contributor

Hi! I noticed the same as @klin333 here. Looking at the ASX Trading Calendar 2022, I believe Jan 3rd should also be included and enforced with a weekday check for Mondays to avoid false flags :)

@lballabio
Copy link
Owner

@pradkrish , do you want to make the further change? Thanks!

@pradkrish
Copy link
Contributor Author

@lballabio Yeah, I can make another PR and link it to the same issue.

@pradkrish pradkrish deleted the pk/update-Oz-calendar branch May 10, 2022 17:46
@gbfredrik
Copy link
Contributor

Hi again,
@pradkrish Do you expect you'll be able to make the final addition before the next QL release? If not, it'd be great if someone could pick it up to ensure that QL 1.27 has the fully corrected calendar. :)

@pradkrish
Copy link
Contributor Author

@gbfredrik I am currently busy working on another library, I wouldn't mind if someone else would like work on this. Thanks for checking.

@gbfredrik
Copy link
Contributor

Thanks, all said and done now! 👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
6 participants