-
Notifications
You must be signed in to change notification settings - Fork 1.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update Australian calendar #1374
Conversation
Thanks for opening this pull request! It might take a while before we look at it, so don't worry if there seems to be no feedback. We'll get to it. |
Congratulations on your first merged pull request! |
not sure if the new year's day change is right, maybe it should be this instead? // New Year's Day (possibly moved to Monday)
|| ((d == 1 || ((d == 2 || d == 3) && w == Monday)) && m == January) |
Hi! I noticed the same as @klin333 here. Looking at the ASX Trading Calendar 2022, I believe Jan 3rd should also be included and enforced with a weekday check for Mondays to avoid false flags :) |
@pradkrish , do you want to make the further change? Thanks! |
@lballabio Yeah, I can make another PR and link it to the same issue. |
Hi again, |
@gbfredrik I am currently busy working on another library, I wouldn't mind if someone else would like work on this. Thanks for checking. |
Thanks, all said and done now! 👍 |
Fixes #1365 and #1366