Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed link error due to using refs to static const #1448

Merged
merged 1 commit into from
Aug 5, 2022

Conversation

novitk
Copy link
Contributor

@novitk novitk commented Aug 5, 2022

solves the linker issue is with references to "static consts" without creating a cpp file, by creating refs locally
For detailed description, see https://stackoverflow.com/questions/16957458/static-const-in-c-class-undefined-reference for details

@boring-cyborg
Copy link

boring-cyborg bot commented Aug 5, 2022

Thanks for opening this pull request! It might take a while before we look at it, so don't worry if there seems to be no feedback. We'll get to it.

@CLAassistant
Copy link

CLAassistant commented Aug 5, 2022

CLA assistant check
All committers have signed the CLA.

@coveralls
Copy link

Coverage Status

Coverage remained the same at 71.174% when pulling 5b88afa on novitk:master into 9087e73 on lballabio:master.

@lballabio
Copy link
Owner

Thanks!

@lballabio lballabio added this to the Release 1.28 milestone Aug 5, 2022
@lballabio lballabio merged commit 9375684 into lballabio:master Aug 5, 2022
@boring-cyborg
Copy link

boring-cyborg bot commented Aug 5, 2022

Congratulations on your first merged pull request!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants