Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add the Queen's Funeral to the list of UK bank holidays #1481

Merged
merged 4 commits into from
Sep 13, 2022

Conversation

Wilsontomass
Copy link
Contributor

@Wilsontomass Wilsontomass commented Sep 12, 2022

Hi,
With the bank holiday announced it would be good to include this date in the list of holidays.

Best,
Tomass

@boring-cyborg
Copy link

boring-cyborg bot commented Sep 12, 2022

Thanks for opening this pull request! It might take a while before we look at it, so don't worry if there seems to be no feedback. We'll get to it.

@CLAassistant
Copy link

CLAassistant commented Sep 12, 2022

CLA assistant check
All committers have signed the CLA.

@gbfredrik
Copy link
Contributor

Resolves #1480 🙂

@lballabio lballabio linked an issue Sep 12, 2022 that may be closed by this pull request
@lballabio lballabio added this to the Release 1.28 milestone Sep 12, 2022
@coveralls
Copy link

coveralls commented Sep 12, 2022

Coverage Status

Coverage increased (+0.0004%) to 71.15% when pulling d6f8262 on Wilsontomass:patch-1 into 3b462bc on lballabio:master.

@lballabio lballabio changed the title Add the Queens Funeral to the list of UK bank holidays Add the Queen's Funeral to the list of UK bank holidays Sep 13, 2022
@lballabio lballabio merged commit 9a2a716 into lballabio:master Sep 13, 2022
@boring-cyborg
Copy link

boring-cyborg bot commented Sep 13, 2022

Congratulations on your first merged pull request!

@tomwhoiscontrary
Copy link
Contributor

Thanks @Wilsontomass!

@lballabio
Copy link
Owner

Also, a note: when using an earlier release, it's possible to update the calendar(s) manually with

UnitedKingdom(UnitedKingdom::Settlement).addHoliday(Date(19, September, 2022));
UnitedKingdom(UnitedKingdom::Exchange).addHoliday(Date(19, September, 2022));
UnitedKingdom(UnitedKingdom::Metals).addHoliday(Date(19, September, 2022));

The change will be propagated to all instances of the same calendar.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

UK bank holiday for the queen's funeral on Monday 19 September 2022
6 participants