Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Configure quantlib-config from CMake #1679

Merged

Conversation

kohnech
Copy link
Contributor

@kohnech kohnech commented May 22, 2023

Building QL-SWIG requires that QuantLib was built via autotools and not CMake since
quantlib-config is missing.

How to reproduce:

  1. Configure/Build QuantLib via CMake, for example:
cmake -DCMAKE_BUILD_TYPE=Release -DCMAKE_INSTALL_PREFIX=../install -DBUILD_SHARED_LIBS=NO ..
cmake --build .
  1. Install QuantLib (path installation)
    cmake --install .
  2. Configure SWIG and build SWIG (Add QL to PATH):
./autogen.sh
./configure --disable-static --disable-test-suite --enable-unity-build CXXFLAGS="-O3 -g0"
make -C Python 
Error:
/bin/sh: 1: quantlib-config: not found

Since we wanna rely on CMake in our pipelines we prefer adding quantlib-config
build product to CMake which is this PR.

Thank you!
Christian

@boring-cyborg
Copy link

boring-cyborg bot commented May 22, 2023

Thanks for opening this pull request! It might take a while before we look at it, so don't worry if there seems to be no feedback. We'll get to it.

@CLAassistant
Copy link

CLAassistant commented May 22, 2023

CLA assistant check
All committers have signed the CLA.

@kohnech kohnech marked this pull request as ready for review May 23, 2023 05:41
@lballabio
Copy link
Owner

Thanks! May you check the CLAassistant comment above?

@coveralls
Copy link

Coverage Status

Coverage: 71.955%. Remained the same when pulling d17122e on Model-Validation:add_quantlib_config_via_cmake into d6896cb on lballabio:master.

@lballabio lballabio added this to the Release 1.31 milestone May 23, 2023
@lballabio lballabio merged commit 1858a75 into lballabio:master May 23, 2023
@boring-cyborg
Copy link

boring-cyborg bot commented May 23, 2023

Congratulations on your first merged pull request!

@gbfredrik gbfredrik deleted the add_quantlib_config_via_cmake branch May 23, 2023 14:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants