Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove use of BOOST_ALL_DYN_LINK #1893

Merged
merged 1 commit into from
Jan 24, 2024
Merged

Conversation

isuruf
Copy link
Contributor

@isuruf isuruf commented Jan 24, 2024

Since we are using header only parts using BOOST_ALL_NO_LIB.

This fixes a linking error on windows.

Copy link

boring-cyborg bot commented Jan 24, 2024

Thanks for opening this pull request! It might take a while before we look at it, so don't worry if there seems to be no feedback. We'll get to it.

@CLAassistant
Copy link

CLAassistant commented Jan 24, 2024

CLA assistant check
All committers have signed the CLA.

@coveralls
Copy link

coveralls commented Jan 24, 2024

Coverage Status

coverage: 72.338%. remained the same
when pulling 216eec2 on isuruf:no-link
into ce606b0 on lballabio:master.

Since we are using header only parts using BOOST_ALL_NO_LIB
@lballabio lballabio added this to the Release 1.34 milestone Jan 24, 2024
@lballabio lballabio merged commit 11f9662 into lballabio:master Jan 24, 2024
52 checks passed
Copy link

boring-cyborg bot commented Jan 24, 2024

Congratulations on your first merged pull request!

@lballabio
Copy link
Owner

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants