GN-4441: Update notulen-prepublish-service and frontend to support template comments #167
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
this should probably also update the frontend too (which introduces support for template comments). |
x-m-el
changed the title
abeforgit
approved these changes
Aug 23, 2023
abeforgit
deleted the
GN-4441-update-notulen-publisher-to-remove-template-comments
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Overview
Update notulen-prepublish-service. Now template comments will be removed when publishing documents.
Updates frontend-gelinkt-notuleren. Now you can add template comments in agenda items.
How to test/reproduce
Probably just like lblod/frontend-gelinkt-notuleren#545 but without having to do override. If you can add template comments and they are hidden in previews, then it must work as expected.