add authorization layer on top of ldes #141
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Rahien
force-pushed
the
karel/lmb-396-authorization-for-ldes
branch
from
212ff5a to
018ce8b
Compare
JonasVanHoof
approved these changes
May 16, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Adds an authorization layer on top of our ldes feed. That way only the public ldes is publically accessible and to use the abb or internal ldes instances you need to be signed in with a user that has the right impersonation rights. Currently both abb and internal are the same one.
How to test
Try and access the public, abb and internal ldes streams page 1. Notice that it only works for the public one.
Run the example query to give the demo vendor access to these endpoints.
Use the vendor login process to log in as an authorized user. Then access all of those pages again and notice they all work.
Here is a postman collection that allows you to perform these steps:
ldes example.json