Ben/lmb 1288 end date mandatarissen #358
Conversation
| @@ -88,6 +89,7 @@ ext:eindeF | |||
| sh:name "Einde"; | |||
| sh:order 800; | |||
| sh:path mandaat:einde; | |||
| fieldOption:endOfDay true; | |||
There was a problem hiding this comment.
Not a fan of naming it endOfDay
There was a problem hiding this comment.
The other option is startOfNextDay, which would be more correct but I think that makes it more confusing. Otherwise don't really have any better ideas.
| } | ||
| INSERT { | ||
| GRAPH ?g { | ||
| ?mandataris mandaat:einde "2025-01-12T23:00:00Z"^^xsd:dateTime . |
There was a problem hiding this comment.
Do we want to add the dcterms:modified here aswell?
There was a problem hiding this comment.
is not really necessary because this is updated in the next migration as well, with a dct:modified.
| ?mandataris dct:modified ?mod. | ||
|
|
||
| ?mandataris mandaat:einde ?end. | ||
| FILTER(?mod > "2024-01-01T00:00:00Z"^^xsd:dateTime) |
There was a problem hiding this comment.
Does this not create errors for mandatarissen that are at the end of a bestuursorgaan binding end? For now the dateInpit still still showing this as an error when the date is after the max date
There was a problem hiding this comment.
Yes true, added a new migration to also set the end dates of bestuursorganen to the beginning of the next day
There was a problem hiding this comment.
they should also be rendered as end of day, but we don't render them anywhere do we?
There was a problem hiding this comment.
We don't render them indeed
There was a problem hiding this comment.
Will remove the migration to set these end dates of bestuursorganen, because those are not final yet, and we will set them correctly whenever we do set them.
| ?mandataris dct:modified ?mod. | ||
|
|
||
| ?mandataris mandaat:einde ?end. | ||
| FILTER(?mod > "2024-01-01T00:00:00Z"^^xsd:dateTime) |
There was a problem hiding this comment.
We are having some issues with data before this date as well, Karel is checking with loket.
Description
Update mandataris form so that the mandataris end date is actually the start of next day.
Add migration to reset end dates for gemeenteraad Zottegem.
Add migration to update end dates previously entered in LMB, so it is actually the start of next day.
How to test
See linked PR.
Links to other PR's