Backwards compatability of article structure nodes #367
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Overview
Use the (now exported)
getRdfaContentElementhelper to target the content-container element in article structure nodes in a way that supports importing the content directly if this element does not exist. This allows to correctly import pre-rdfa-aware html documents.connected issues and PRs:
Depends on lblod/ember-rdfa-editor#1077
Setup
Need to link the feat/content-predicate branch of the editor.
How to test/reproduce
Get an export from an old version of the article structure plugin, for example from staging. Set the variable
presetContentintests/dummy/app/controllers/besluit-sample.ts#334to be equal to this html. Alternatively you can add it to the sample-data.ts of your locally linked editor repo.Challenges/uncertainties
There are some issues with the exact content of some properties, for example those with datatype 'rdf:XMLLiteral` as the html has changed.