Rdfa/actual structure compat #379
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
piemonkey
force-pushed
the
rdfa/actual-structure-compat
branch
3 times, most recently
from
26e1f19 to
52b9036
Compare
2 tasks
abeforgit
approved these changes
Jan 25, 2024
piemonkey
force-pushed
the
rdfa/actual-structure-compat
branch
from
52b9036 to
639aeea
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Overview
Some backwards compatibility fixes for article structure plugin nodetypes.
connected issues and PRs:
Requires lblod/ember-rdfa-editor#1128
Setup
npm ishould be enough as it's referencing the git commit it needs.How to test/reproduce
Paste different old html containing article structures into the 'custom html' input in the editor. HTML can be taken from e.g. qa GN. Check that all the relationships are shown and clicking on outgoing relationships and backlinks works. Refresh and make sure it still works.
Challenges/uncertainties
Aside from dependency problems, a difficulty was not knowing when something was already broken just being hidden by prosemirror's default behaviour. It would also be very valuable to have a collection of old documents that we can test with.
Checks PR readiness