Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

More article structure parsing and aligning sample with RS frontend #387

Merged
merged 2 commits into from
Feb 15, 2024

Conversation

piemonkey
Copy link
Collaborator

Overview

Some more parsing problems for article structure nodes (I could have sworn I fixed these already :s ).
I also changed the configuration of the editor in the editable-nodes-regulatory-statement test page to be almost the same as that on the RS frontend project.

connected issues and PRs:

lblod/ember-rdfa-editor#1139

Setup

N/A

How to test/reproduce

Construct a RS document on QA, export, then import into the RS editable node sample page and confirm the nodes are all recreated correctly.

Challenges/uncertainties

It seems there are some problems with parsing, as noted in chat.

Checks PR readiness

  • UI: works on smaller screen sizes
  • UI: feedback for any loading/error states
  • Check if dummy app is correctly updated
  • Check cancel/go-back flows
  • changelog
  • npm lint
  • no new deprecations

Copy link
Collaborator

@elpoelma elpoelma left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Article structures mostly come over correctly from the regulatory-statements application. I did notice that copy-pasting does not work and I really have to export/import. This is probably due to another issue though.

I did notice a small mistake in the parseDOM of the structure-header-number node though.

On the issues with parsing/serializing literals with the XMLLiteral datatype. I'm not sure whether it is that much of a problem? I'll still need to take a look at your other PR on the blackbox tests.

@elpoelma elpoelma self-requested a review February 15, 2024 10:42
@piemonkey piemonkey merged commit 38d2078 into feat/rdfa-editing-ui Feb 15, 2024
1 check passed
@piemonkey piemonkey deleted the rdfa/more-structs branch February 15, 2024 12:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants