-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update editor to rdfa-backwards-compatibility build #395
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
When trying to insert anything from the sidebar (in the index route), I get an error:
Uncaught TypeError: can't access property "indexOf", tagName is undefined
Interesting, will check if I can reproduce that. |
Does it occur with a specific action? |
It happens in the |
That specific issue should be fixed now, it was an issue in the |
Overview
This PR updates the editor to the rdfa-backwards-compatible build (lblod/ember-rdfa-editor#1155)
This build includes some API changes:
rdfaAttrSpec
is now a function...WithConfig
configurable nodespecsThis PR also includes some changes to the citation plugin to support the
rdfaAware
system.connected issues and PRs:
lblod/ember-rdfa-editor#1155
How to test/reproduce
pnpm start
rdfaAware
mode and the rdfa-features should work as expectedChallenges/uncertainties
It does not seem very useful to also convert all the nodespecs provided by this package to be backwards compatible.
Checks PR readiness