Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Removal of redundant attributes and parse-rules from decision node-specs #410

Merged
merged 10 commits into from
Apr 29, 2024

Conversation

elpoelma
Copy link
Collaborator

@elpoelma elpoelma commented Apr 23, 2024

Overview

This PR removes redundant attributes and parse-rules from the following node-specs:

  • besluit
  • besluit_title
  • description
  • motivering
  • article_container
  • besluit_article
  • besluit_article_content

The parse-rules of these nodespecs should be able to parse both the old and the new representations.

connected issues and PRs:

None

How to test/reproduce

  • Start the dummy app
  • Import the sample DecisionTemplate or copy over a document from GN
  • Ensure that all RDFa contained in the decision is correctly parsed and stored.

Challenges/uncertainties

At the moment, there are still issues in the parsing logic of decision-articles, I will tackle these issues in a seperate PR.

Checks PR readiness

  • UI: works on smaller screen sizes
  • UI: feedback for any loading/error states
  • Check if dummy app is correctly updated
  • Check cancel/go-back flows
  • changelog
  • npm lint

@elpoelma elpoelma self-assigned this Apr 23, 2024
@elpoelma elpoelma changed the title Removing redundant attributes and parse-rules from decision node-specs Removal of redundant attributes and parse-rules from decision node-specs Apr 25, 2024
Copy link
Collaborator

@piemonkey piemonkey left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I can't remember the case that these were added for, but they should be easy to reinstate if we find problems again.

@abeforgit abeforgit merged commit 847383d into feat/rdfa-editing-ui Apr 29, 2024
0 of 3 checks passed
@abeforgit abeforgit deleted the internal/cleanup-decision-nodes branch April 29, 2024 18:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants