Adjust behaviour of decision nodes in terms of UX #414
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ting/defining/selectable)
…e-prosemirror-properties
…e-prosemirror-properties
Base automatically changed from
fix/rdfa-aware-decision-articles
to
feat/rdfa-editing-ui
April 29, 2024 18:45
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Overview
This PR slightly adjusts some attributes on the nodespecs related to decisions. Specifically, it restores the UX behaviour of the decision related nodes to how these behave on the latest stable version of this package.
The following node-spec properties have been adjusted:
isolatingselectableThis PR mostly exists to ensure the UX of decisions remains mostly the same for users.
How to test/reproduce
The decision-related nodes should now behave similarly to how they behave on the latest stable version of the plugins.
Most nodes are no longer isolating or selectable.
Checks PR readiness